[SDK] Add 2 new Pay functions: convertFiatToCrypto and convertCryptoToFiat #5457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 57fa96b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kien-ngo
changed the title
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
kien-ngo
requested review from
joaquim-verges,
gregfromstl,
MananTank,
jnsdls and
edwardysun
as code owners
size-limit report 📦
|
kien-ngo
force-pushed
the
kien/pay-convert-endpoints
branch
from
a613e2e to
980e2d3
Compare
kien-ngo
force-pushed
the
kien/pay-convert-endpoints
branch
from
980e2d3 to
d99b778
Compare
kien-ngo
changed the title
kien-ngo
force-pushed
the
kien/pay-convert-endpoints
branch
from
d99b778 to
b14876f
Compare
kien-ngo
force-pushed
the
kien/pay-convert-endpoints
branch
from
07afcee to
f1e9de2
Compare
kien-ngo
removed
the
DO NOT MERGE
joaquim-verges
approved these changes
Dec 1, 2024
| "thirdweb": minor | ||
| --- | ||
|
|
||
| Add 2 new Pay functions: convertFiatToCrypto and convertCryptoToFiat |
There was a problem hiding this comment.
can you add a quick example in the changeset?
kien-ngo
force-pushed
the
kien/pay-convert-endpoints
branch
from
f1e9de2 to
ac08a47
Compare
Merge activity
|
…oFiat (#5457) CNCT-2369 ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces two new functions for converting between fiat and crypto currencies in the `thirdweb` package, along with corresponding tests and endpoints. ### Detailed summary - Added `convertFiatToCrypto` and `convertCryptoToFiat` functions. - Created endpoints for fiat to crypto and crypto to fiat conversions. - Implemented tests for both conversion functions, covering various scenarios and error handling. - Updated documentation with examples for the new functions. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/pay-convert-endpoints
branch
from
ac08a47 to
57fa96b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNCT-2369
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR introduces two new functions for converting between fiat and crypto values, specifically
convertFiatToCryptoandconvertCryptoToFiat. It also adds corresponding endpoints and tests for these functions.Detailed summary
convertFiatToCryptoandconvertCryptoToFiatfunctions.